-
-
Notifications
You must be signed in to change notification settings - Fork 929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace syntaxes with our forks #4685
Conversation
f5478f7
to
0cf46bc
Compare
I've updated the pull request to use our forks. The lint task is failing on the types check:
And 1 test related to #4119 is, understandably, failing:
I suspect because the workaround to ignore nested template literals relies on the AST that has changed (and is now hopefully fixed). If the underlying bug in the parser is fixed, we should remove the workaround (and its corresponding test). I don't have any time left today, so feel free to jump into this pull request if anyone has time. |
Thanks for updating the pull request. I've confirmed locally that #4119 is resolved and that the source file is no longer corrupted when using import styled, { css } from "styled-components";
const Message = styled.p`
padding: 10px;
${(props) => css`
color: #b02d00;
`}
`; Produces: jeddy3@jeddy3 stylelint-test % npx stylelint "sources/**/fix.js"
sources/js/fix.js
5:5 ✖ Expected indentation of 0 spaces indentation
6:2 ✖ Expected indentation of 4 spaces indentation The I think we should use this release to drum up support for the CSS-in-JS parser by announcing in the release tweet that we're now using our own fork of the CSS-in-JS and we need help to fix bugs with it. We can add the |
I think we should create a separate issue, and preferably not release a new version until this issue is fixed. Because it's a breaking issue, and we know about it. Thank you for finding it! |
Agreed. New issue created. This pull request looks good to me. I think we can merge. |
I made a pull request for this branch. #4695 |
|
Closes #4645
Closes #4119
It doesn't work yet. First, we need to release
@stylelint/postcss-css-in-js
and@stylelint/postcss-markdown
. Then we can test and make changes to this PR.