Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix false positive for part pseudo-element in selector-pseudo-element-no-unknown #4604

Merged
merged 1 commit into from Feb 16, 2020
Merged

Fix false positive for part pseudo-element in selector-pseudo-element-no-unknown #4604

merged 1 commit into from Feb 16, 2020

Conversation

bennypowers
Copy link
Member

Which issue, if any, is this issue related to?

fixes #4589

Is there anything in the PR that needs further explanation?

No, it's self-explanatory.

jeddy3
jeddy3 approved these changes Feb 15, 2020
View reviewed changes
Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

LGTM.

As an aside, I dug a little deeper after you posted your issue. Learning about the shadow tree was interesting, and I was fascinated to read that the Firefox UI uses web components and the ::part pseudo-element!

@bennypowers
Copy link
Member Author

yeah web components FTW. Thanks for taking an interest.

hudochenkov
hudochenkov approved these changes Feb 15, 2020
View reviewed changes
Copy link
Member

@hudochenkov hudochenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great first contribution! Thank you!

@jeddy3 jeddy3 changed the title Fix part pseudo selector Fix false positive for part pseudo-element in selector-pseudo-element-no-unknown Feb 16, 2020
@jeddy3 jeddy3 merged commit 4e1042b into stylelint:master Feb 16, 2020
@jeddy3
Copy link
Member

jeddy3 commented Feb 16, 2020

Changelog entry:

  • Fixed: selector-pseudo-element-no-unknown false positives for ::part pseudo-element (#4604).

@bennypowers bennypowers deleted the part-pseudo-selector branch February 16, 2020 00:56
@snyk-bot snyk-bot mentioned this pull request Mar 13, 2020
Closed
This was referenced Mar 29, 2020
Merged
Merged
This was referenced Apr 5, 2020
Closed
Closed
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hudochenkov hudochenkov hudochenkov approved these changes

@jeddy3 jeddy3 jeddy3 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix false positives for ::part in selector-pseudo-element-no-unknown
3 participants
@bennypowers @jeddy3 @hudochenkov