Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor CLI options definition #4530

Merged
merged 4 commits into from Jan 11, 2020
Merged

Refactor CLI options definition #4530

merged 4 commits into from Jan 11, 2020

Commits on Jan 9, 2020

  1. Refactor CLI options definition 

    This aims to prepare for type-checking `cli.js` and does NOT type-check actually.

- Camelize option names for type-checking.
- Add missing `type` for some options.
- Sort options alphabetically for readability.
- Add a unit test for the definition (A system test is too much for this purpose).

See <#4504 (comment)> for details.
    @ybiquitous
    ybiquitous committed Jan 9, 2020
    Copy the full SHA
    58e26e5 View commit details
    Browse the repository at this point in the history

  2. More readable code using _.kebabCase

    @ybiquitous
    ybiquitous committed Jan 9, 2020
    Copy the full SHA
    e4aaa95 View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2020

  1. Use spread syntax for meowOptions

    @ybiquitous
    ybiquitous committed Jan 11, 2020
    Copy the full SHA
    668bbf6 View commit details
    Browse the repository at this point in the history

  2. Refactor checkInvalidCLIOptions() more efficient

    @ybiquitous
    ybiquitous committed Jan 11, 2020
    Copy the full SHA
    9c9d363 View commit details
    Browse the repository at this point in the history