Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Process multiple spaces in media (#4509) #4513

Merged
merged 2 commits into from Jan 9, 2020
Merged

Process multiple spaces in media (#4509) #4513

merged 2 commits into from Jan 9, 2020

Conversation

fanich37
Copy link
Member

@fanich37 fanich37 commented Jan 6, 2020

Which issue, if any, is this issue related to?

It should close #4509 .

Is there anything in the PR that needs further explanation?

No, it's self explanatory.

@hudochenkov
Copy link
Member

Could you also add check for tabs \t, please? /[ \t]/.test(node.before)

hudochenkov
hudochenkov approved these changes Jan 7, 2020
View reviewed changes
Copy link
Member

@hudochenkov hudochenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@XhmikosR
Copy link
Member

XhmikosR commented Jan 7, 2020

I wonder are newlines allowed here too?

@hudochenkov
Copy link
Member

I believe we usually define whitespace as spaces and tabs in our rules, that's we we have rules like function-comma-space-after and function-comma-newline-after.

@hudochenkov hudochenkov merged commit d9dbce2 into stylelint:master Jan 9, 2020
@hudochenkov
Copy link
Member

  • Fixed: media-feature-parentheses-space-inside false negatives for multiple spaces (#4513).

@fanich37 fanich37 deleted the bugfix/mfpsi-handle-spaces branch January 9, 2020 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hudochenkov hudochenkov hudochenkov approved these changes

@ntwb ntwb ntwb approved these changes

@darwintantuco darwintantuco darwintantuco approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

media-feature-parentheses-space-inside did not remove space
5 participants
@fanich37 @hudochenkov @XhmikosR @ntwb @darwintantuco