Remove unused condition

[hudochenkov]

Which issue, if any, is this issue related to?

Closes #4328.

Is there anything in the PR that needs further explanation?

I'm not sure I understood the problem correctly ¯\_(ツ)_/¯ But look like removing incorrect condition fixes types issue, and doesn't break any test.

[vankop]

Sorry for my bad explanation. Your code does not check end (right now it does not work also), but I think it is not by design. Example disabledRanges:

{
   'block-no-empty': [{start: 0, end: 0}]
}

for this range command enable all should throw error (fall in this condition) by design as I understand. Your fix ignore this behaviour

[hudochenkov]

I guess we need tests for this first. Even failing.

[hudochenkov]

@vankop do you think we can figure out the problem in the coming week? I would like to release new stylelint soon. Don't want to release another major release in case disabled ranges fix is a breaking change.

[vankop]

Actually I don't understand reason of throwing error here... Maybe skip command is better

[hudochenkov]

We have only one test, where this condition is true:

stylelint/lib/__tests__/disableRanges.test.js

Lines 604 to 610 in 2dfd779

	it('enable all without disabling any', () => {
	return testDisableRanges('/* stylelint-enable */', () => {
	throw new Error('should have errored');
	}).catch((err) => {
	expect(err.reason).toBe('No rules have been disabled');
	});
	});

[vankop]

So we need to add test case:

/* stylelint-disable-line block-no-empty */
/* stylelint-enable */

and update code to catch error in this case =)

[hudochenkov]

I've added test. This test isn't failing and without removing extra condition. In fact, we have no tests which would use run condition _.last(ranges.end) :) So I guess it was just a bug, that this condition was there in the first place :)

[vankop]

We must expect error here since there is nothing to enable, if I understand correctly condition with No rules have been disabled error =)

[hudochenkov]

You're right :)

[vankop]

Hah, I found a bug in ranges assignment, I will do fix

[vankop]

test expectation was wrong.. see https://github.com/stylelint/stylelint/blob/master/lib/__tests__/fixtures/disableOptions/disabled-ranges-2.css

[hudochenkov]

Great job, @vankop! Github won't let me approve, but I approve :)

Everything has changed.

[hudochenkov]

• Fixed: overlapping disabled ranges edge case (#4497).