Ignore map property name (#4375) #4450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hudochenkov
requested changes
Nov 29, 2019
| @@ -18,6 +19,8 @@ const messages = ruleMessages(ruleName, { | |||
| rejected: (unit) => `Unexpected unknown unit "${unit}"`, | |||
| }); | |||
|
|
|||
| const mapPropertyNameIndexOffset = 4; | |||
There was a problem hiding this comment.
Could you explain what this variable for, please? I don't understand from the following.
There was a problem hiding this comment.
The map property name (in map cleared from comments & spaces) always has index that being divided by 4 gives remainder equals 0 (e.g. 0, 4, 8 etc).
The naming of this const definitely has to be changed since it's not clear. Any suggestions? Or may be comment would be enough?
There was a problem hiding this comment.
I think comment in the code would be enough.
There was a problem hiding this comment.
Added comment with explanation.
Co-Authored-By: Aleks Hudochenkov <aleks@hudochenkov.com>
Co-Authored-By: Aleks Hudochenkov <aleks@hudochenkov.com>
hudochenkov
approved these changes
Nov 30, 2019
ntwb
approved these changes
Dec 1, 2019
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should close #4375 .
No, it's self explanatory.