Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #4404

Merged
merged 2 commits into from Nov 12, 2019
Merged

Update dependencies #4404

merged 2 commits into from Nov 12, 2019

Conversation

hudochenkov
Copy link
Member

Updated all dependencies prior release.

Didn't update TypeScript, because it has a bug microsoft/TypeScript#34869.

@@ -138,7 +138,7 @@
"lint:types": "tsc",
"lint": "npm-run-all --parallel lint:*",
"pretest": "npm-run-all --serial lint flow prettier:check",
"prettier:check": "prettier \"**/*.js\" --list-different",
"prettier:check": "prettier \"**/*.js\" --check",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will give human-friendly status messages.

https://prettier.io/docs/en/cli.html#check

@ybiquitous
Copy link
Member

I see the following packages should not be updated:

However, should we update other packages?

$ npm outdated
Package                  Current   Wanted   Latest  Location
flow-bin                 0.100.0  0.100.0  0.111.3  stylelint
globby                     9.2.0    9.2.0   10.0.1  stylelint
jest-watch-typeahead       0.4.0    0.4.2    0.4.2  stylelint
postcss-sass               0.4.1    0.4.2    0.4.2  stylelint
postcss-selector-parser    3.1.1    3.1.1    6.0.2  stylelint
remark-cli                 7.0.0    7.0.1    7.0.1  stylelint
string-width               4.1.0    4.2.0    4.2.0  stylelint
typescript                 3.6.4    3.7.2    3.7.2  stylelint

@hudochenkov
Copy link
Member Author

There are few new versions since my last commit.

flow-bin we don't update, because we're moving to TypeScript.

postcss-selector-parser has own PR.

Other I'll update.

@ybiquitous
Copy link
Member

postcss-selector-parser has own PR.

I missed #3988. Thanks. 👍

@github-actions
Copy link
Contributor

Coverage Status

Coverage increased (+0.0003%) to 96.889% when pulling 7505b12 on update-dependencies into 334f615 on master.

Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 😄

@hudochenkov hudochenkov merged commit 3320783 into master Nov 12, 2019
@hudochenkov hudochenkov deleted the update-dependencies branch November 12, 2019 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants