Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix to ignore SCSS namespace #4379

Merged
merged 7 commits into from Nov 5, 2019
Merged

Fix to ignore SCSS namespace #4379

merged 7 commits into from Nov 5, 2019

Conversation

kimulaco
Copy link
Member

Issue: Rules are not ignored when using SCSS namespace (#4378)

There is a rule to ignore SCSS variable in "lib/utils/isStandardSyntaxValue.js".
I added a rule there that also ignores the SCSS namespace.

@kimulaco kimulaco changed the title Add rules to ignore SCSS namespace Fix to ignore SCSS namespace Oct 25, 2019
alexander-akait
alexander-akait requested changes Oct 25, 2019
View reviewed changes
Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests

@kimulaco
Copy link
Member Author

I added the following test.

  • Accept LESS variable
  • Accept SCSS variable
  • Accept SCSS namespace

Verification, please.

@hudochenkov
Copy link
Member

Please, add tests to isStandardSyntaxValue.test.js as well. And merge master into your branch. We fixed issue with our CI in master and would like to see that CI is passes for your PR.

@kimulaco
Copy link
Member Author

Added a test to "isStandardSyntaxValue.test.js".
And merged from a master, CI was also successful!

hudochenkov
hudochenkov approved these changes Oct 26, 2019
View reviewed changes
Copy link
Member

@hudochenkov hudochenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Thank you!

@hudochenkov hudochenkov merged commit 6580cef into stylelint:master Nov 5, 2019
@hudochenkov
Copy link
Member

  • Fixed: font-family-no-missing-generic-family-keyword false positives for Sass-variables with namespaces (#4378).

@tomanovy tomanovy mentioned this pull request Dec 6, 2019
Closed
@kimulaco kimulaco deleted the feature/scss-namespace branch December 26, 2020 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hudochenkov hudochenkov hudochenkov approved these changes

@alexander-akait alexander-akait alexander-akait approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kimulaco @hudochenkov @alexander-akait