Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix false positives for shared-line comment as a first child #4360

Merged
merged 1 commit into from Oct 17, 2019
Merged

Fix false positives for shared-line comment as a first child #4360

merged 1 commit into from Oct 17, 2019

Conversation

hudochenkov
Copy link
Member

@hudochenkov hudochenkov commented Oct 16, 2019 •
edited

Which issue, if any, is this issue related to?

Fixes #2835.

Is there anything in the PR that needs further explanation?

There were false positives when beginning of the rule/at-rule was on a different line than start of the block ({).

@hudochenkov
Fix false positives for shared-line comment as a first child
610780e 
There were false positives when beginning of the rule/at-rule was on a different
line than start of the block (`{`).
@github-actions
Copy link
Contributor

Coverage Status

Coverage remained the same at 96.526% when pulling 610780e on fix-shared-line-comments into 94c7a28 on master.

@hudochenkov hudochenkov merged commit 58e4c24 into master Oct 17, 2019
@hudochenkov hudochenkov deleted the fix-shared-line-comments branch October 17, 2019 09:36
@hudochenkov
Copy link
Member Author

  • Fixed: comment-empty-line-before false positives for selector lists and shared-line comments (#4360).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntwb ntwb ntwb approved these changes

@vankop vankop vankop approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix false positives for selector lists and shared-line comments in comment-empty-line-before
3 participants
@hudochenkov @ntwb @vankop