Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

False negatives for rules with nested rules at selector-max-* #4357

Merged
merged 1 commit into from Oct 17, 2019
Merged

False negatives for rules with nested rules at selector-max-* #4357

merged 1 commit into from Oct 17, 2019

Conversation

hudochenkov
Copy link
Member

Which issue, if any, is this issue related to?

Closes #2990

Is there anything in the PR that needs further explanation?

Now rules report every selector which violates the rule. Before that only deepest selector was reported.

@github-actions
Copy link
Contributor

Coverage Status

Coverage decreased (-0.005%) to 96.521% when pulling f4f3dd7 on fix-selector-max-type into 94c7a28 on master.

alexander-akait
alexander-akait approved these changes Oct 16, 2019
View reviewed changes
Copy link
Member

@alexander-akait alexander-akait left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

vankop
vankop approved these changes Oct 17, 2019
View reviewed changes
Copy link
Member

@vankop vankop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@hudochenkov hudochenkov merged commit d95ef1b into master Oct 17, 2019
@hudochenkov hudochenkov deleted the fix-selector-max-type branch October 17, 2019 09:38
@hudochenkov
Copy link
Member Author

  • Fixed: selector-max-* false negatives for rules with nested rules (#4357).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntwb ntwb ntwb approved these changes

@alexander-akait alexander-akait alexander-akait approved these changes

@vankop vankop vankop approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

False negatives for top-level rules with nested rules selector-max-*
4 participants
@hudochenkov @ntwb @alexander-akait @vankop