Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix case when raws.after/before could be undefined or null #4313

Merged
merged 2 commits into from Oct 9, 2019
Merged

Fix case when raws.after/before could be undefined or null #4313

merged 2 commits into from Oct 9, 2019

Conversation

vankop
Copy link
Member

@vankop vankop commented Sep 27, 2019

Which issue, if any, is this issue related to?

fix #4309

Is there anything in the PR that needs further explanation?

Nothing

@alexander-akait
Copy link
Member

Can we add tests?

@vankop
Copy link
Member Author

vankop commented Sep 27, 2019

Can we add tests?

Need to ask in issue for reproduction. As I understand it was css-in-js

@vankop
Copy link
Member Author

vankop commented Sep 27, 2019 •
edited

looks like coverall is down..

@vankop
Copy link
Member Author

vankop commented Sep 28, 2019 •
edited

I suggest to force this fix without tests. Looks like this is common problem when postcss returns typeof root.raws.after !== 'string'

I can not reproduce problem myself

@github-actions
Copy link
Contributor

Coverage Status

Coverage increased (+0.0003%) to 96.542% when pulling 8a9d4d9 on fix-no-eol-whitespace into 08467ae on master.

@vankop
Copy link
Member Author

vankop commented Oct 8, 2019

@hudochenkov can you release this fix, please?

@hudochenkov
Copy link
Member

I'll try to do release tomorrow.

@hudochenkov
Copy link
Member

What changelog entry could be for this PR? Both PR title and issue title aren't suitable for changelog.

@alexander-akait
Copy link
Member

@hudochenkov fix crashing/stucking stylelint for css-in-js/other case name?

@hudochenkov hudochenkov merged commit 2f272bc into master Oct 9, 2019
@hudochenkov hudochenkov deleted the fix-no-eol-whitespace branch October 9, 2019 12:10
@hudochenkov
Copy link
Member

  • Fixed: no-eol-whitespace parsing problems for non-standard syntaxes (#4313).

@vankop
Copy link
Member Author

vankop commented Oct 9, 2019

@hudochenkov sorry for writing here, take a look on latest commit in master, CI build failed.

@hudochenkov
Copy link
Member

Yeah, I see. Restarted it. Because CI 5 hours ago was successful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hudochenkov hudochenkov hudochenkov approved these changes

@alexander-akait alexander-akait alexander-akait approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stylelint --fix gets stuck with React.js inline styles
3 participants
@vankop @alexander-akait @hudochenkov