Add --noglob cli option #4286
Closed
Add --noglob cli option #4286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vankop
requested changes
Sep 17, 2019
vankop
previously approved these changes
Sep 20, 2019
There was a problem hiding this comment.
I think this work is enough.
However there is some usage of globby options still, see https://github.com/stylelint/stylelint/blob/master/lib/standalone.js#L202
Maybe we need to use process.cwd() explicitly it such cases
|
I am 👎 on this, solution should be #4193 (comment), not new option for CLI |
| @@ -170,7 +170,7 @@ module.exports = function( | |||
| fileList = [fileList]; | |||
| } | |||
|
|
|||
| if (!options.disableDefaultIgnores) { | |||
| if (!options.disableDefaultIgnores && !options.noglob) { | |||
There was a problem hiding this comment.
In this case, ALWAYS_IGNORED_GLOBS is not working as expected with noglob, it is not good idea
|
@evilebottnawi So, if I understand you correctly, you suggest to use kind of heuristic:
or there is another idea? |
|
eslint use this code |
|
Code from eslint looks good, i think we should use this logic too |
|
Any other suggestions? |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4193 and is non-breaking alternative for #4254 that can be accepted in minor release.
Tests and flow types have been implemented