Add ignoreSelectors option to property-no-unknown #4275
Conversation
There was a problem hiding this comment.
@dprgarner Thanks for the PR!
I've made some documentation requests.
| @@ -130,3 +130,25 @@ a { | |||
| -moz-overflow-scrolling: center; | |||
| } | |||
| ``` | |||
|
|
|||
| ### `ignoreSelectors: ["/regex/", /regex/, "string"]` | |||
There was a problem hiding this comment.
Let's move this under the ignoreProperties docs so these similar options are grouped.
|
|
||
| ### `ignoreSelectors: ["/regex/", /regex/, "string"]` | ||
|
|
||
| Some CSS extensions allow arbitrary child properties of certain selectors and pseudo-classes, which shouldn't be checked against a whitelist of known properties. One such example is [ICSS](https://github.com/css-modules/icss), which defines `:export` and `:import` pseudo-classes allowing any valid CSS property name to be nested in their declaration blocks. |
There was a problem hiding this comment.
We use standard CSS syntax in our docs. Code related to methodologies or language extensions can confuse users unfamiliar with them. Also, methodologies like ICSS will come and go, but CSS will stick around. Using plain CSS in our examples has made our docs resilient over the past 5 years.
I think we can strip this paragraph out and just use something like :root in the example as ignoreProperties already shows an example of regex usage. For example:
ignoreSelectors: ["/regex/", /regex/, "string"]
Given:
[":root"]The following patterns are not considered violations:
:root {
my-property: blue;
}
| // Is the property a child of an ignored selector? | ||
| const { selector } = decl.parent; | ||
|
|
||
| if (selector && optionsMatches(options, "ignoreSelectors", selector)) { |
There was a problem hiding this comment.
Thanks for PR, I think it will be better to move this check right after ignoreProperties check. This is up to you.
There was a problem hiding this comment.
Makes sense. Benchmarks look the same.
|
Closes #4270
I think it's okay as-is. It's implementing what was discussed on the issue, with docs and tests (and a small typo fix).