Deprecate createRuleTester API #4265
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm marking it as blocked, until we resolve #4267 :) |
hudochenkov
requested changes
Sep 13, 2019
|
|
||
| module.exports = deprecate( | ||
| createRuleTester, | ||
| "createRuleTester deprecated, please use https://github.com/stylelint/jest-preset-stylelint instead" |
There was a problem hiding this comment.
Suggested change
| "createRuleTester deprecated, please use https://github.com/stylelint/jest-preset-stylelint instead" | |
| "createRuleTester deprecated. See https://github.com/stylelint/stylelint/issues/4267" |
jest-preset-stylelint is not ready to be used. So it's better to point to discussion instead.
| @@ -32,7 +31,6 @@ api.lint = standalone; | |||
| api.rules = requiredRules; | |||
| api.formatters = formatters; | |||
| api.createPlugin = createPlugin; | |||
| api.createRuleTester = createRuleTester; | |||
There was a problem hiding this comment.
We need to put this back, as we discussed in #4267. We'll only deprecate this API in the following release.
hudochenkov
changed the title
|
Superseded by #4279 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #2454
loading this module cost to much https://gist.github.com/vankop/f83bdeda2cae617b4a801d8e210454ef
Suggest developers to load
~/lib/testUtils/createRuleTesterdirectly if needednothing