Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #3147 #4237

Merged
merged 4 commits into from Sep 4, 2019
Merged

fix #3147 #4237

merged 4 commits into from Sep 4, 2019

Conversation

vankop
Copy link
Member

@vankop vankop commented Aug 31, 2019

Which issue, if any, is this issue related to?

fixes #3147

Is there anything in the PR that needs further explanation?

I add some ability to make suggestions to improve DX

hudochenkov
hudochenkov requested changes Sep 4, 2019
View reviewed changes
Copy link
Member

@hudochenkov hudochenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall the feature is nice.

I like that you added suggestion for typos!

lib/reportUnknownRuleNames.js Outdated Show resolved Hide resolved
lib/reportUnknownRuleNames.js Outdated Show resolved Hide resolved
lib/utils/levenshteinDistance.js Show resolved Hide resolved
lib/reportUnknownRuleNames.js Outdated Show resolved Hide resolved
hudochenkov
hudochenkov approved these changes Sep 4, 2019
View reviewed changes
Copy link
Member

@hudochenkov hudochenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hudochenkov hudochenkov merged commit 0cd30ca into master Sep 4, 2019
@hudochenkov hudochenkov deleted the issues-3147 branch September 4, 2019 15:49
@hudochenkov
Copy link
Member

  • Changed: Display a violation at 1:1 for each file instead of throwing an error on unrecognised rules (#4237).

@ota-meshi ota-meshi mentioned this pull request Dec 24, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hudochenkov hudochenkov hudochenkov approved these changes

@alexander-akait alexander-akait alexander-akait approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Display a violation at 1:1 for each file instead of throwing an error on unrecognised rules
3 participants
@vankop @hudochenkov @alexander-akait