New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce unicode-bom rule #4225
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job!
/cc @stylelint/core somebody can review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Only few small changes required.
@hudochenkov thanks! Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A minor nit on the verbiage for singular examples, happy to merge as is.
Ideally we update all instances of this where a single example is used
@ntwb thanks, fixed.
I can do this for all the rules in a separate PR. |
|
Closes #3792.
No, it's self explanatory.
I think it's better to add the auto-fix functionality separately, because first we need to fix the bug in stylelint that causes BOM to be cut out in any auto-fix run (#4228).