Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix indentation rule #4177

Merged
merged 2 commits into from Jul 31, 2019
Merged

fix indentation rule #4177

merged 2 commits into from Jul 31, 2019

Conversation

vankop
Copy link
Member

@vankop vankop commented Jul 27, 2019

Which issue, if any, is this issue related to?

fixes #4056

Is there anything in the PR that needs further explanation?

nothing

hudochenkov
hudochenkov requested changes Jul 27, 2019
View reviewed changes
Copy link
Member

@hudochenkov hudochenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, add tests when indentation done with spaces.

@vankop vankop requested a review from hudochenkov July 27, 2019 15:30
hudochenkov
hudochenkov approved these changes Jul 31, 2019
View reviewed changes
Copy link
Member

@hudochenkov hudochenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hudochenkov hudochenkov merged commit b39d3a1 into stylelint:master Jul 31, 2019
@hudochenkov
Copy link
Member

  • Fixed: indentation false positives for <style> tag with multiline attributes (#4177).

@vankop vankop deleted the fix-indentation-rule branch July 31, 2019 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hudochenkov hudochenkov hudochenkov approved these changes

@alexander-akait alexander-akait alexander-akait approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix indentation rule in Vue file <style> tag with multiline attributes
3 participants
@vankop @hudochenkov @alexander-akait