Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

always returns boolean stylelintError #4174

Merged
merged 1 commit into from Jul 27, 2019
Merged

always returns boolean stylelintError #4174

merged 1 commit into from Jul 27, 2019

Conversation

vankop
Copy link
Member

@vankop vankop commented Jul 26, 2019

Which issue, if any, is this issue related to?

Fixes #3041

Is there anything in the PR that needs further explanation?

Added ignoreFile system test

@vankop vankop force-pushed the stylelinterror-always-boolean branch from 18fe429 to 391789c Compare July 26, 2019 13:01
alexander-akait
alexander-akait approved these changes Jul 26, 2019
View reviewed changes
Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like small breaking change, but for me it is bug in our design api

@vankop
Copy link
Member Author

vankop commented Jul 26, 2019

Looks like small breaking change, but for me it is bug in our design api

Yep, it is breaking change =(

@vankop vankop force-pushed the stylelinterror-always-boolean branch from 391789c to 292066b Compare July 26, 2019 13:30
hudochenkov
hudochenkov approved these changes Jul 27, 2019
View reviewed changes
Copy link
Member

@hudochenkov hudochenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@hudochenkov hudochenkov merged commit db54404 into stylelint:master Jul 27, 2019
@hudochenkov
Copy link
Member

  • Changed: always return stylelintError as a boolean (#4174).

@hudochenkov hudochenkov mentioned this pull request Jul 31, 2019
Merged
@vankop vankop deleted the stylelinterror-always-boolean branch July 31, 2019 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hudochenkov hudochenkov hudochenkov approved these changes

@alexander-akait alexander-akait alexander-akait approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Always returns stylelintError with boolean values
3 participants
@vankop @hudochenkov @alexander-akait