Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix no-duplicate-selectors #4173

Merged
merged 2 commits into from Jul 27, 2019

Conversation

vankop
Copy link
Member

@vankop vankop commented Jul 26, 2019

Which issue, if any, is this issue related to?

Fixes #4113

Is there anything in the PR that needs further explanation?

current test cases can not find this problem, to reproduce in current master branch commit ->1178f2d2d4c7d83d12ad4ec55b686a7bf7e28995 add:
expect(output.results[0].warnings).toHaveLength(1);
here https://github.com/stylelint/stylelint/blob/master/jest-setup.js#L92

run node node_modules/jest/bin/jest.js lib/rules/no-duplicate-selectors/__tests__/index.js

@vankop vankop changed the title fix #4113 fix no-duplicate-selectors Jul 26, 2019
@vankop vankop force-pushed the fix-no-duplicate-selector branch from 5e84b45 to a40099b Compare July 26, 2019 13:21
@hudochenkov
Copy link
Member

Please, don't force push if someone left review to your PR. This way we could see what have changed since last review.

Don't worry about clean Git history. We always use “squash and merge” so all commit gets squashed into one on PR merge.

@hudochenkov
Copy link
Member

One more thing. Since you're member of stylelint team you can now use main repository to work on your PRs. This way it's simpler for you, because you don't need to keep your fork updated :)

@vankop
Copy link
Member Author

vankop commented Jul 26, 2019

One more thing. Since you're member of stylelint team you can now use main repository to work on your PRs. This way it's simpler for you, because you don't need to keep your fork updated :)

But then I need to delete branches to keep repo clean =)

Please, don't force push if someone left review to your PR. This way we could see what have changed since last review.

I have forgotten about it sorry =(

@hudochenkov
Copy link
Member

But then I need to delete branches to keep repo clean =)

After merge new button “Delete branch” appears in the PR :)

Copy link
Member

@hudochenkov hudochenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@vankop
Copy link
Member Author

vankop commented Jul 26, 2019

@hudochenkov Did not found out why tests failed

@alexander-akait
Copy link
Member

Maybe conditional race on windows, we need search place who do this 😕

@hudochenkov
Copy link
Member

I happens sometimes for unknown reason.

@hudochenkov hudochenkov merged commit c6f65da into stylelint:master Jul 27, 2019
@hudochenkov
Copy link
Member

  • Fixed: no-duplicate-selectors false positives for selectors in the same selector list (#4173).

@vankop vankop deleted the fix-no-duplicate-selector branch July 27, 2019 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

False positive in no-duplicate-selector
3 participants