New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix no-duplicate-selectors #4173
fix no-duplicate-selectors #4173
Conversation
5e84b45
to
a40099b
Compare
Please, don't force push if someone left review to your PR. This way we could see what have changed since last review. Don't worry about clean Git history. We always use “squash and merge” so all commit gets squashed into one on PR merge. |
One more thing. Since you're member of stylelint team you can now use main repository to work on your PRs. This way it's simpler for you, because you don't need to keep your fork updated :) |
But then I need to delete branches to keep repo clean =)
I have forgotten about it sorry =( |
After merge new button “Delete branch” appears in the PR :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job!
@hudochenkov Did not found out why tests failed |
Maybe conditional race on windows, we need search place who do this 😕 |
I happens sometimes for unknown reason. |
|
Fixes #4113
current test cases can not find this problem, to reproduce in current
master
branch commit ->1178f2d2d4c7d83d12ad4ec55b686a7bf7e28995
add:expect(output.results[0].warnings).toHaveLength(1);
here https://github.com/stylelint/stylelint/blob/master/jest-setup.js#L92
run
node node_modules/jest/bin/jest.js lib/rules/no-duplicate-selectors/__tests__/index.js