fix max-line-length rule #4169
fix max-line-length rule #4169
Conversation
|
So many changes, I don't understand what it does :( I wonder would this issue be fixed if it was updating RexExp to accept new lines: - const urlArgumentsLength = execall(/url\((.*)\)/gi, lineText).reduce(
+ const urlArgumentsLength = execall(/url\(([\s\S]*)\)/gi, lineText).reduce( |
vankop@5677f47 |
|
current code execute regex line-by-line thats why it falls ( |
| const skippedSubStrings = []; | ||
| let skippedSubStringsIndex = 0; | ||
|
|
||
| EXCLUDED_PATTERNS.forEach(pattern => |
There was a problem hiding this comment.
all excluded patterns create array of excluded indexes, for instance:
url
(
"blabla"
)
will return [[7, 15]], where 7 is first " and 15 is next after "blabla"
| @@ -75,32 +116,21 @@ const rule = function(maxLength, options, context) { | |||
| } | |||
|
|
|||
| const rawLineLength = nextNewlineIndex - match.endIndex; | |||
| const excludedLength = skippedSubStrings[skippedSubStringsIndex] | |||
There was a problem hiding this comment.
compute excluded substring length (for current line), for instance:
url(
\t\t"bla bla"\u0020);
will give excludedLength equals to "bla bla".length on line 2
There was a problem hiding this comment.
it is a bit tricky since
url("bla \
bla \
");
will give excludedLength equals to "bla \\".length on line 1
| Math.min(end, endSubString) - Math.max(start, startSubString); | ||
|
|
||
| // Current substring is out of range for next lines | ||
| if (endSubString <= end) { |
There was a problem hiding this comment.
current line last index + 1 is over current excluded range end
| ]; | ||
|
|
||
| // Excluded substring does not presented in current line | ||
| if (end < startSubString) { |
There was a problem hiding this comment.
current excluded range is not presented on current line
| } | ||
|
|
||
| // Compute excluded substring size regarding to current line indexes | ||
| const excluded = |
There was a problem hiding this comment.
Compute excluded substring size regarding to current line indexes =)
|
@hudochenkov i have add some explanation |
|
Fixes #4059
Nothing