Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert adding Node.js 12 in AppVeyor #4107

Merged
merged 1 commit into from Jun 7, 2019
Merged

Conversation

hudochenkov
Copy link
Member

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is blocker for azure pipelines?

@hudochenkov
Copy link
Member Author

Windows builds failing. And when they are not — false error about passed tests.

@alexander-akait
Copy link
Member

And when they are not — false error about passed tests.

It is wrong. It is visual bug. When tests failed they exit with code 1 and tests failed. When it is passed they exit with 0 code and tests passed. I can not understand why this is a problem. This is just a visual bug.

@alexander-akait
Copy link
Member

I will fix windows bugs and they ready to merge

@ntwb
Copy link
Member

ntwb commented Jun 7, 2019

I’m currently mobile but will check this issue out an the Azure Pipelines issue, I’m not confident of Azure Pipelines current false reporting and would prefer we wait for node.js 12.x to stabilise on AppVeyor before switching to Azure as it stands right now

@alexander-akait
Copy link
Member

alexander-akait commented Jun 7, 2019

refer we wait for node.js 12.x to stabilise on AppVeyor before switching to Azure as it stands right now

Why? 😞 AppVeyor always was very bad and looks as hack for windows tests

Previously AppVeyor added node@10 after 6-8 mouth after release. It is incredible long

@ntwb
Copy link
Member

ntwb commented Jun 7, 2019

AppVeyor has served us reliably for many years, at times it has been slow and they added us to a higher performance plan for free, and yes updates have also not been as fast as we would prefer, but right now the stability of AppVeyor without Node.js v12 is preferable than the unreliable and false reporting Azure Pipelines as a “new” service is offering IMHO

@alexander-akait
Copy link
Member

higher performance plan for free

Where? We still not have parallelism so it doesn't have sense, we still wait each build before run previously?

yes updates have also not been as fast as we would prefer

Because we don't have alternative for windows.

right now the stability of AppVeyor without Node.js v12 is preferable than the unreliable and false reporting Azure Pipelines

Wrong, we have right reporting, it is bug in jest because they output invalid ansi code for windows console and will be fixed in next major release.

Azure Pipelines as. a “new” service is offering IMHO

It is works since 2016/2017, it is not new service.

IMHO AppVeyor is not listen community, all feedback will be ignored, my emails often was unanswered and any bugs in their contains was ignore, this is not too good behavior for developers.

This is not a Microsoft advertisement, they just did it right and it works well.

@hudochenkov hudochenkov merged commit 6cb083b into master Jun 7, 2019
@hudochenkov hudochenkov deleted the revert-appveyor-change branch June 7, 2019 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants