Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better error output for --report-needless-disables #4071

Merged
merged 3 commits into from May 30, 2019
Merged

Better error output for --report-needless-disables #4071

merged 3 commits into from May 30, 2019

Conversation

muan
Copy link
Member

@muan muan commented May 6, 2019

Which issue, if any, is this issue related to?

Closes #4066.

Is there anything in the PR that needs further explanation?

When running stylelint CLI with --report-needless-disables, the output:

Before

assets/foo.css
start: 2

After

assets/foo.css
unused rule: color-named, start line: 2, end line: 4

hudochenkov
hudochenkov approved these changes May 30, 2019
View reviewed changes
Copy link
Member

@hudochenkov hudochenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great! Thank you!

Sorry for the late response.

@hudochenkov hudochenkov merged commit ce578ba into stylelint:master May 30, 2019
@muan muan deleted the better-disable-error branch May 30, 2019 15:07
@hudochenkov
Copy link
Member

  • Added: rule names for --report-needless-disables output (#4071).

@shawnbot shawnbot mentioned this pull request Sep 25, 2019
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hudochenkov hudochenkov hudochenkov approved these changes

@alexander-akait alexander-akait alexander-akait approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Better error output for --report-needless-disables
3 participants
@muan @hudochenkov @alexander-akait