New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix false positives for interpolation in function-calc-no-invalid #4046
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add examples from original issue to tests, please? It might have something to do with calc
expression being multi-line.
@@ -50,6 +50,9 @@ | |||
"(" return 'LPAREN'; | |||
")" return 'RPAREN'; | |||
|
|||
#\{([\s\S]*?)\} return 'UNKNOWN'; // scss variable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// scss interpolation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for pointing out!
I fixed this.
@hudochenkov Thank you for your review! a {
width: calc(
#{$min-value} +
#{strip-unit($max-value - $min-value)} *
(100vw - #{$min-vw})
);
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks!
|
When will this be released? Want to turn on the rule, but this issue prevent me. |
This issue is also a blocker for us 👍 |
@Bigdragon13th @benjamincharity it will be released this week. |
Closes #3908
No, it's self explanatory.