New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop Node.js required version from 8.15.0 to 8.7.0 #4032
Conversation
What if we, or our dependency, uses a feature introduced in 8.3.0 for example? |
I tested locally with
This is because micromatch uses the object spread operator which is behind a flag until 8.3.0. micromatch has According to node.green the following versions added new features:
Even though stylelint works with 8.3.0 I suggest we go with 8.7.0 as that's the lowest feature-complete version of 8 (and it's compatible with AWS). This seems to me to be the best compromise. |
Thanks, makes sense, have bumped it to 8.7.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@hudochenkov Did you have any more thoughts on this? I can put out a patch release this morning if this goes in. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
Via #4000 (comment)
As AWS Labda currenty only supports Node.js 8.10, let's drop the required version down to 8.0.0
We can add this to the next minor release 10.0.1