Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix false positives for dollar variables in function-linear-gradient-no-nonstandard-direction #4027

Merged
merged 1 commit into from Apr 15, 2019
Merged

Fix false positives for dollar variables in function-linear-gradient-no-nonstandard-direction #4027

merged 1 commit into from Apr 15, 2019

Conversation

ccabrales
Copy link
Contributor

Which issue, if any, is this issue related to?

Closes #4014

Is there anything in the PR that needs further explanation?

Returns early if the first value is non-standard syntax.

jeddy3
jeddy3 approved these changes Apr 14, 2019
View reviewed changes
Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

hudochenkov
hudochenkov approved these changes Apr 14, 2019
View reviewed changes
Copy link
Member

@hudochenkov hudochenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jeddy3 jeddy3 merged commit 68cd18f into stylelint:master Apr 15, 2019
@jeddy3
Copy link
Member

jeddy3 commented Apr 15, 2019

  • Fixed: function-linear-gradient-no-nonstandard-direction false positives for dollar variables (#4027).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hudochenkov hudochenkov hudochenkov approved these changes

@jeddy3 jeddy3 jeddy3 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix false positives for dollar variables in function-linear-gradient-no-nonstandard-direction
3 participants
@ccabrales @jeddy3 @hudochenkov