Add at-rule-property-requirelist #3997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeddy3
approved these changes
Apr 2, 2019
There was a problem hiding this comment.
@cahamilton Thanks for this!
Sorry about the delay getting around to reviewing it... I was on holiday.
The PR looks good to me!
jeddy3
changed the title
|
|
@jeddy3 All good mate, hope you had a nice break @hudochenkov @jeddy3 And thank you both for the review 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3985. Adds new rule
at-rule-property-requirelist.Not specifically. Addresses request for new rule, with specs outlined in the discussion here: #3985 (comment). If theres any issues, just let me know!