Throw error on non-existent files unless allow-empty-input is enabled

flow-typed/stylelint.js

@@ -147,5 +147,6 @@ export type stylelint$standaloneOptions = {
   customSyntax?: string,
   formatter?: "compact" | "json" | "string" | "unix" | "verbose" | Function,
   disableDefaultIgnores?: boolean,
-  fix?: boolean
+  fix?: boolean,
+  allowEmptyInput: boolean
 };

lib/__tests__/ignore.test.js

@@ -191,8 +191,11 @@ describe("extending config with ignoreFiles glob ignoring one by negation", () =
 });
 
 describe("specified `ignorePath` file ignoring one file", () => {
-  let results;
+  const noFilesErrorMessage = new Error(
+    "The specified `files` glob returns no results"
+  );
   let actualCwd;
+  let errorMessage;
 
   beforeAll(() => {
     actualCwd = process.cwd();
@@ -212,17 +215,26 @@ describe("specified `ignorePath` file ignoring one file", () => {
         }
       },
       ignorePath: path.join(__dirname, "fixtures/ignore.txt")
-    }).then(data => (results = data.results));
+    })
+      .then(() => {
+        throw new Error("should not have succeeded");
+      })
+      .catch(actualError => {
+        errorMessage = actualError;
+      });
   });
 
   it("no files read", () => {
-    expect(results).toHaveLength(0);
+    expect(errorMessage).toEqual(noFilesErrorMessage);
   });
 });
 
 describe("specified `ignorePattern` file ignoring one file", () => {
-  let results;
+  const noFilesErrorMessage = new Error(
+    "The specified `files` glob returns no results"
+  );
   let actualCwd;
+  let errorMessage;
 
   beforeAll(() => {
     actualCwd = process.cwd();
@@ -242,17 +254,26 @@ describe("specified `ignorePattern` file ignoring one file", () => {
         }
       },
       ignorePattern: "fixtures/empty-block.css"
-    }).then(data => (results = data.results));
+    })
+      .then(() => {
+        throw new Error("should not have succeeded");
+      })
+      .catch(actualError => {
+        errorMessage = actualError;
+      });
   });
 
   it("no files read", () => {
-    expect(results).toHaveLength(0);
+    expect(errorMessage).toEqual(noFilesErrorMessage);
   });
 });
 
 describe("specified `ignorePattern` file ignoring two files", () => {
-  let results;
+  const noFilesErrorMessage = new Error(
+    "The specified `files` glob returns no results"
+  );
   let actualCwd;
+  let errorMessage;
 
   beforeAll(() => {
     actualCwd = process.cwd();
@@ -278,11 +299,17 @@ describe("specified `ignorePattern` file ignoring two files", () => {
         "fixtures/empty-block.css",
         "fixtures/no-syntax-error.css"
       ]
-    }).then(data => (results = data.results));
+    })
+      .then(() => {
+        throw new Error("should not have succeeded");
+      })
+      .catch(actualError => {
+        errorMessage = actualError;
+      });
   });
 
   it("no files read", () => {
-    expect(results).toHaveLength(0);
+    expect(errorMessage).toEqual(noFilesErrorMessage);
   });
 });
 
@@ -416,6 +443,9 @@ describe("using codeFilename and ignoreFiles with configBasedir", () => {
 });
 
 describe("file in node_modules", () => {
+  const noFilesErrorMessage = new Error(
+    "The specified `files` glob returns no results"
+  );
   const lint = () =>
     standalone({
       files: [`${fixturesPath}/node_modules/test.css`],
@@ -427,13 +457,20 @@ describe("file in node_modules", () => {
     });
 
   it("is ignored", () => {
-    return lint().then(output => {
-      expect(output.results).toHaveLength(0);
-    });
+    return lint()
+      .then(() => {
+        throw new Error("should not have succeeded");
+      })
+      .catch(actualError => {
+        expect(actualError).toEqual(noFilesErrorMessage);
+      });
   });
 });
 
 describe("file in bower_components", () => {
+  const noFilesErrorMessage = new Error(
+    "The specified `files` glob returns no results"
+  );
   const lint = () =>
     standalone({
       files: [`${fixturesPath}/bower_components/test.css`],
@@ -445,9 +482,13 @@ describe("file in bower_components", () => {
     });
 
   it("is ignored", () => {
-    return lint().then(output => {
-      expect(output.results).toHaveLength(0);
-    });
+    return lint()
+      .then(() => {
+        throw new Error("should not have succeeded");
+      })
+      .catch(actualError => {
+        expect(actualError).toEqual(noFilesErrorMessage);
+      });
   });
 });
 

lib/__tests__/standalone.test.js

@@ -114,10 +114,28 @@ it("standalone without input css and file(s) should throw error", () => {
   );
 });
 
-it("standalone with non-existent-file quietly exits", () => {
+it("standalone with non-existent-file throws an error", () => {
+  const expectedError = new Error(
+    "The specified `files` glob returns no results"
+  );
+
   return standalone({
     files: `${fixturesPath}/non-existent-file.css`,
     config: configBlockNoEmpty
+  })
+    .then(() => {
+      throw new Error("should not have succeeded");
+    })
+    .catch(actualError => {
+      expect(actualError).toEqual(expectedError);
+    });
+});
+
+it("standalone with non-existent-file and allowEmptyInput enabled quietly exits", () => {
+  return standalone({
+    files: `${fixturesPath}/non-existent-file.css`,
+    config: configBlockNoEmpty,
+    allowEmptyInput: true
   }).then(linted => {
     expect(typeof linted.output).toBe("string");
     expect(linted.results).toHaveLength(0);

lib/cli.js

@@ -125,7 +125,8 @@ const EXIT_CODE_ERROR = 2;
     stdinFilename: any,
     syntax: any,
     v: string,
-    version: string
+    version: string,
+    allowEmptyInput: boolean
   },
   input: any,
   help: any,
@@ -153,7 +154,8 @@ const EXIT_CODE_ERROR = 2;
   maxWarnings?: any,
   syntax?: any,
   disableDefaultIgnores?: any,
-  ignorePattern?: any
+  ignorePattern?: any,
+  allowEmptyInput?: boolean
 }*/
 
 const meowOptions /*: meowOptionsType*/ = {
@@ -278,6 +280,10 @@ const meowOptions /*: meowOptionsType*/ = {
       --version, -v
 
         Show the currently installed version of stylelint.
+
+      --alow-empty-input
+
+        When glob pattern matches no files, the process will exit without throwing an error.
   `,
   flags: {
     cache: {
@@ -478,6 +484,10 @@ module.exports = (argv /*: string[]*/) /*: Promise<void>|void*/ => {
     return;
   }
 
+  if (cli.flags.allowEmptyInput) {
+    optionsBase.allowEmptyInput = cli.flags.allowEmptyInput;
+  }
+
   return Promise.resolve()
     .then(() => {
       // Add input/code into options

lib/standalone.js

@@ -42,6 +42,7 @@ module.exports = function(
   const reportNeedlessDisables = options.reportNeedlessDisables;
   const maxWarnings = options.maxWarnings;
   const syntax = options.syntax;
+  const allowEmptyInput = options.allowEmptyInput || false;
   const useCache = options.cache || false;
   let fileCache;
   const startTime = Date.now();
@@ -198,6 +199,10 @@ module.exports = function(
       );
 
       if (!filePaths.length) {
+        if (!allowEmptyInput) {
+          throw new Error("The specified `files` glob returns no results");
+        }
+
         return Promise.all([]);
       }