Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix false negatives for nested at-rules in selector-max-* #3959

Merged
merged 10 commits into from Apr 3, 2019
Merged

Fix false negatives for nested at-rules in selector-max-* #3959

merged 10 commits into from Apr 3, 2019

Conversation

ccabrales
Copy link
Contributor

@ccabrales ccabrales commented Feb 20, 2019

Which issue, if any, is this issue related to?

Closes #3947

Is there anything in the PR that needs further explanation?

This seems to solve the problem for selector-max-type, but I wanted to put up a POC before moving on to the other rules to see if I'm moving in the right direction. Feedback is appreciated.

.gitignore Outdated
@@ -4,3 +4,4 @@ node_modules
.eslintcache
package-lock.json
yarn.lock
**/.idea/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just use .idea

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It shouldn't be in this project .gitignore, because it's not related to stylelint directly. How to setup global .gitignore: https://gist.github.com/subfuzion/db7f57fff2fb6998a16c

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤷‍♂️ sure I'll remove it. Makes no difference to me

@jeddy3
Copy link
Member

jeddy3 commented Feb 21, 2019

@ccabrales Thanks for so much for making a start on this! The POC looks good to me and the tests give me confidence. I think we can roll the change out to the other selector-max-* rules.

@jeddy3 jeddy3 mentioned this pull request Feb 21, 2019
6 tasks
@ccabrales ccabrales changed the title POC for fixing false negatives for nested at-rules in selector-max-* Fix false negatives for nested at-rules in selector-max-* Feb 22, 2019
@ccabrales
Copy link
Contributor Author

@jeddy3 I updated the other selector-max-* rules where needed, and added some tests for ones that didn't need code updates for future-proofing them. Let me know if I need to make any tweaks.

Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ccabrales Excellent work! Thanks for updating the other selector-max-* rules.

Looks good to me!

@ccabrales
Copy link
Contributor Author

@jeddy3 My pleasure! Is there a timeline on getting final approval and into a release?

@jeddy3
Copy link
Member

jeddy3 commented Feb 27, 2019

Is there a timeline on getting final approval and into a release?

It's just waiting on another team member to find the time to review it. It looks like everyone is pretty busy of late. If no one finds time by the weekend, I'll merge it then so it's in the next release.

@ccabrales
Copy link
Contributor Author

@jeddy3 Hey, wanted to check in for an update?

Copy link
Member

@hudochenkov hudochenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Thank you!

@hudochenkov hudochenkov merged commit 843eea6 into stylelint:master Apr 3, 2019
@hudochenkov
Copy link
Member

  • Fixed: selector-max-* false negatives for nested at-rules (#3959).

@jeddy3
Copy link
Member

jeddy3 commented Apr 3, 2019

Hey, wanted to check in for an update?

@ccabrales Sorry about the delay getting this in. We're all been busy of late. We're planning to do a release in a week and a half's time. You can track the progress of that in #3954

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Fix false negatives for nested at-rules in selector-max-*
4 participants