New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix false negatives for nested at-rules in selector-max-* #3959
Conversation
.gitignore
Outdated
@@ -4,3 +4,4 @@ node_modules | |||
.eslintcache | |||
package-lock.json | |||
yarn.lock | |||
**/.idea/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just use .idea
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It shouldn't be in this project .gitignore
, because it's not related to stylelint directly. How to setup global .gitignore
: https://gist.github.com/subfuzion/db7f57fff2fb6998a16c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤷♂️ sure I'll remove it. Makes no difference to me
@ccabrales Thanks for so much for making a start on this! The POC looks good to me and the tests give me confidence. I think we can roll the change out to the other |
@jeddy3 I updated the other |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ccabrales Excellent work! Thanks for updating the other selector-max-*
rules.
Looks good to me!
@jeddy3 My pleasure! Is there a timeline on getting final approval and into a release? |
It's just waiting on another team member to find the time to review it. It looks like everyone is pretty busy of late. If no one finds time by the weekend, I'll merge it then so it's in the next release. |
@jeddy3 Hey, wanted to check in for an update? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job! Thank you!
|
@ccabrales Sorry about the delay getting this in. We're all been busy of late. We're planning to do a release in a week and a half's time. You can track the progress of that in #3954 |
Closes #3947
This seems to solve the problem for selector-max-type, but I wanted to put up a POC before moving on to the other rules to see if I'm moving in the right direction. Feedback is appreciated.