Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add disallowInList option to no-duplicate-selectors #3936

Merged
merged 5 commits into from Feb 19, 2019
Merged

Add disallowInList option to no-duplicate-selectors #3936

merged 5 commits into from Feb 19, 2019

Conversation

devsnice
Copy link
Contributor

@devsnice devsnice commented Feb 4, 2019

Which issue, if any, is this issue related to?

Closes #3931

@devsnice
Copy link
Contributor Author

devsnice commented Feb 4, 2019

I don't understand why test in ignore.test.js was failed, maybe it's wired with some deps?

@hudochenkov
Copy link
Member

@devsnice this happens from time to time. We don't know what causes it. I've restarted the job.

jeddy3
jeddy3 requested changes Feb 5, 2019
View reviewed changes
Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@devsnice Thanks. It's looking good.

I've made two suggestions to the README.

lib/rules/no-duplicate-selectors/README.md Outdated Show resolved Hide resolved
lib/rules/no-duplicate-selectors/README.md Outdated Show resolved Hide resolved
@jeddy3 jeddy3 changed the title Issue 3931: add disallowInList option to no-duplicate-selectors rule Add disallowInList option to no-duplicate-selectors Feb 5, 2019
jeddy3 and others added 2 commits February 5, 2019 15:02
@jeddy3 @devsnice
Update lib/rules/no-duplicate-selectors/README.md
dac0791 
Co-Authored-By: devsnice <devsnice@gmail.com>
@jeddy3 @devsnice
Update lib/rules/no-duplicate-selectors/README.md
fabc92a 
Co-Authored-By: devsnice <devsnice@gmail.com>
@devsnice
Copy link
Contributor Author

devsnice commented Feb 6, 2019

@devsnice Thanks. It's looking good.

I've made two suggestions to the README.

Thanks! Can you restart job?

jeddy3
jeddy3 approved these changes Feb 6, 2019
View reviewed changes
Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeddy3 jeddy3 mentioned this pull request Feb 18, 2019
Closed
6 tasks
@jeddy3 jeddy3 merged commit 90cd748 into stylelint:master Feb 19, 2019
@jeddy3
Copy link
Member

jeddy3 commented Feb 19, 2019

Changelog:

  • Added: disallowInList to no-duplicate-selectors (#3936).

@jeddy3 jeddy3 mentioned this pull request Mar 5, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeddy3 jeddy3 jeddy3 approved these changes

@alexander-akait alexander-akait alexander-akait approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@devsnice @hudochenkov @jeddy3 @alexander-akait