Fix false negatives for isStandardSyntaxDeclaration
#3933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gucong3000
force-pushed
the
issues_3930
branch
5 times, most recently
from
9ff574b
to
43f695c
Compare
gucong3000
force-pushed
the
issues_3930
branch
from
43f695c
to
d9f6d68
Compare
hudochenkov
reviewed
Feb 5, 2019
| }); | ||
| it("url with less interpolation at the end without quotes", () => { | ||
| expect(isStandardSyntaxUrl("some/@{less-variable}")).toBeTruthy(); | ||
| expect(isStandardSyntaxUrl("some/@{less-variable}")).toBeFalsy(); |
There was a problem hiding this comment.
Actually, it's a bug fix. Interpolation makes URL non-standard. There are tests for Sass interpolation and they all negative.
alexander-akait
approved these changes
Apr 3, 2019
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3930
No, it's self explanatory.