Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix false positives for negative numbers in function-calc-no-invalid #3921

Merged
merged 1 commit into from Apr 3, 2019
Merged

Fix false positives for negative numbers in function-calc-no-invalid #3921

merged 1 commit into from Apr 3, 2019

Conversation

ota-meshi
Copy link
Member

Which issue, if any, is this issue related to?

Closes #3912

Is there anything in the PR that needs further explanation?

e.g. "No, it's self explanatory."

jeddy3
jeddy3 approved these changes Feb 5, 2019
View reviewed changes
Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM.

@jeddy3 jeddy3 mentioned this pull request Feb 18, 2019
Closed
6 tasks
hudochenkov
hudochenkov approved these changes Apr 3, 2019
View reviewed changes
Copy link
Member

@hudochenkov hudochenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hudochenkov hudochenkov merged commit e92d5e0 into master Apr 3, 2019
@hudochenkov hudochenkov deleted the issue-3912 branch April 3, 2019 14:51
@hudochenkov
Copy link
Member

  • Fixed: function-calc-no-invalid false positives for negative numbers (#3921).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hudochenkov hudochenkov hudochenkov approved these changes

@jeddy3 jeddy3 jeddy3 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ota-meshi @hudochenkov @jeddy3