Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lint staged files on pre-commit hook #3906

Merged
merged 3 commits into from
Jan 19, 2019
Merged

Lint staged files on pre-commit hook #3906

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f2f6020
Run `remark` for committing markdown files
ybiquitous Jan 17, 2019
edd4a48
Run `eslint` on pre-commit
ybiquitous Jan 19, 2019
548b225
Append `--fix` option on pre-commit `eslint`
hudochenkov Jan 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,11 @@
"lint-staged": {
"*.js": [
"prettier --write",
"eslint --max-warnings=0",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[note] I excluded --cache option to lint files in the clean state. I think it no performance problem because of not for all JS files in the project.

ybiquitous marked this conversation as resolved.
Show resolved Hide resolved
"git add"
],
"*.md": [
"remark --quiet --frail"
]
},
"eslintConfig": {
Expand Down