Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable --fix while using a processor and display message #3873

Merged
merged 2 commits into from Jan 10, 2019
Merged

Disable --fix while using a processor and display message #3873

merged 2 commits into from Jan 10, 2019

Conversation

gucong3000
Copy link
Member

Which issue, if any, is this issue related to?

Closes #3223

Is there anything in the PR that needs further explanation?

No, it's self explanatory.

jeddy3
jeddy3 requested changes Jan 3, 2019
View reviewed changes
Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. I've made a suggestion for the message.

lib/getPostcssResult.js Outdated Show resolved Hide resolved
@jeddy3 @gucong3000
Update lib/getPostcssResult.js
f90021a 
Co-Authored-By: gucong3000 <gucong@gmail.com>
jeddy3
jeddy3 approved these changes Jan 3, 2019
View reviewed changes
Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

hudochenkov
hudochenkov approved these changes Jan 10, 2019
View reviewed changes
Copy link
Member

@hudochenkov hudochenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hudochenkov hudochenkov merged commit e2072c6 into master Jan 10, 2019
@hudochenkov hudochenkov deleted the issue-3223 branch January 10, 2019 17:41
@hudochenkov
Copy link
Member

  • Changed: Autofixing will be disabled if it is used with stylelint processors (#3873).

I've mention “stylelint processors” to avoid confusion with preprocessors like Sass.

@snyk-bot snyk-bot mentioned this pull request Sep 23, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hudochenkov hudochenkov hudochenkov approved these changes

@jeddy3 jeddy3 jeddy3 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Disable --fix while using a processor and display message
3 participants
@gucong3000 @hudochenkov @jeddy3