Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add autofix to selector-max-empty-lines #3717

Merged
merged 4 commits into from May 1, 2019
Merged

Add autofix to selector-max-empty-lines #3717

merged 4 commits into from May 1, 2019

Conversation

vanilla-wave
Copy link
Member

Which issue, if any, is this issue related to?

Closes #3611", added autofix to selector-max-empty-lines

Is there anything in the PR that needs further explanation?

After fix number empty lines in a row <= max

@vankop
Copy link
Member

vankop commented Oct 12, 2018 •
edited

Thanks for contribution!
@vizet could you please add some tests with css comments? For instance,

.foo\r\n#this is comment\r\n{}
.foo\n#this is comment\n{}
.foo\n\n#this is comment\n\n#and this is comment too\n\n{}

@ntwb
Copy link
Member

ntwb commented Nov 27, 2018

Some hints on how tests could be added to this PR can be taken from the value-list-max-empty-lines PR in #3814

@vanilla-wave vanilla-wave deleted the selector-max-empty-lines__autofix branch April 10, 2019 20:31
@vanilla-wave vanilla-wave restored the selector-max-empty-lines__autofix branch April 10, 2019 20:39
@vanilla-wave vanilla-wave reopened this Apr 12, 2019
@jeddy3
Copy link
Member

jeddy3 commented Apr 13, 2019

Just a lint error to fix please:

/home/travis/build/stylelint/stylelint/lib/rules/selector-max-empty-lines/index.js
71:13 error Expected blank line before this statement padding-line-between-statements

@vanilla-wave vanilla-wave force-pushed the selector-max-empty-lines__autofix branch from 09d42e7 to 12493b1 Compare April 13, 2019 23:23
@vanilla-wave
Copy link
Member Author

Just a lint error to fix please:

/home/travis/build/stylelint/stylelint/lib/rules/selector-max-empty-lines/index.js
71:13 error Expected blank line before this statement padding-line-between-statements

Sorry, i had old version repository. I rebased on master

jeddy3
jeddy3 approved these changes Apr 14, 2019
View reviewed changes
Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, especially for updating those hundreds of tests!

LGTM.

hudochenkov
hudochenkov approved these changes May 1, 2019
View reviewed changes
Copy link
Member

@hudochenkov hudochenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@hudochenkov hudochenkov merged commit 56f7234 into stylelint:master May 1, 2019
@hudochenkov
Copy link
Member

  • Added: selector-max-empty-lines autofix (#3717).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hudochenkov hudochenkov hudochenkov approved these changes

@jeddy3 jeddy3 jeddy3 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add autofix to selector-max-empty-lines
5 participants
@vanilla-wave @vankop @ntwb @jeddy3 @hudochenkov