Add autofix to selector-pseudo-element-case #3672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ota-meshi
requested changes
Sep 16, 2018
| @@ -6,6 +6,7 @@ const { messages, ruleName } = rule; | |||
| testRule(rule, { | |||
| ruleName, | |||
| config: ["lower"], | |||
| fix: true, | |||
There was a problem hiding this comment.
Could you add a test case with comments in the selector?
There was a problem hiding this comment.
Unfortunately it won't work until update to the last version of postcss-selector-parser (#3284).
I don't sure that it makes sense to add some workaround.
There was a problem hiding this comment.
In selectorCombinatorSpaceChecker.js, it choose the selector to pass to parseSelector beforehand.
There was a problem hiding this comment.
I added few new test cases with comments inside selectors.
…pseudo-element-case # Conflicts: # docs/user-guide/rules.md
|
Hi @evilebottnawi, @ntwb, @hudochenkov, |
vankop
approved these changes
Aug 31, 2019
hudochenkov
reviewed
Sep 4, 2019
alexander-akait
approved these changes
Sep 7, 2019
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3662
Example
code:
fixed: