New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add autofix to max-empty-lines #3667
Add autofix to max-empty-lines #3667
Conversation
6084f30
to
a2b1aa4
Compare
I'm looking forward to the following test case errors being resolved. FAILlib/rules/max-empty-lines/__tests__/index.js
●max-empty-lines › reject › [1] › "<div>\n<style>\n/* horse */\n\n\n</style>\n</div>" › no description
expect(received).toEqual(expected)
Expected value to equal:
[]
Received:
[{"column": 1, "line": 5, "rule": "max-empty-lines", "severity": "error", "text": "Expected no more than 1 empty line (max-empty-lines)"}]
Difference:
- Expected
+ Received
- Array []
+ Array [
+ Object {
+ "column": 1
+ "line": 5
+ "rule": "max-empty-lines"
+ "severity": "error"
+ "text": "Expected no more than 1 empty line (max-empty-lines)"
+ }
+ ]
128 | })
129 |.then(({ output warnings })=> {
> 130 | expect(output.results[0].warnings).toEqual(warnings);
|^
131 | expect(output.results[0].parseErrors).toEqual([]);
132 | });
133 | }); |
I opened issue #3707. |
@EliazTray hi! Would you like to look into this PR again? |
a2b1aa4
to
d507ed7
Compare
d507ed7
to
06adff2
Compare
Hi! I got this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! But 5 of 7 testRule()
are missing fix: true
, without it Jest won't check autofixing.
I'm sorry for missing some test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Thank you!
@stylelint/contributors can we have a second review, please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
e.g. "Closes #3612 ".
e.g. "No, it's self explanatory."