Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor to improve types for no-extra-semicolons rule #5768

Merged
merged 1 commit into from Dec 20, 2021
Merged

Refactor to improve types for no-extra-semicolons rule #5768

merged 1 commit into from Dec 20, 2021

Conversation

ybiquitous
Copy link
Member

Which issue, if any, is this issue related to?

Part of #4496

Is there anything in the PR that needs further explanation?

  • Remove // @ts-nocheck to enable type-checking.
  • Narrow the scope of some local variables.

@ybiquitous
Refactor to improve types for no-extra-semicolons rule
ed9c368 
- Remove `// @ts-nocheck` to enable type-checking.
- Narrow the scope of some local variables.
@ybiquitous ybiquitous mentioned this pull request Dec 9, 2021
Closed
jeddy3
jeddy3 approved these changes Dec 18, 2021
View reviewed changes
Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM.

@jeddy3 jeddy3 merged commit b9785cd into main Dec 20, 2021
@jeddy3 jeddy3 deleted the refactor-types-for-no-extra-semicolons branch December 20, 2021 18:23
@sync-by-unito sync-by-unito bot mentioned this pull request Jan 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeddy3 jeddy3 jeddy3 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ybiquitous @jeddy3