Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dashed idents in our examples of custom constructs #5523

Closed
4 tasks done
jeddy3 opened this issue Sep 12, 2021 · 3 comments · Fixed by #5555
Closed
4 tasks done

Use dashed idents in our examples of custom constructs #5523

jeddy3 opened this issue Sep 12, 2021 · 3 comments · Fixed by #5555
Labels
status: wip is being worked on by someone type: umbrella a group of related issues

Comments

@jeddy3
Copy link
Member

jeddy3 commented Sep 12, 2021

Clearly describe the documentation issue

We should use dashed idents in our examples of custom constructs to align with the specs (see example 7), e.g. @--custom rather than @custom.

This is in line with Stylelint's emphasis on standard CSS in our rules and docs.

Ref: #5520 (comment)

  • At-rules
  • Functions
  • Units
  • Selectors
@jeddy3 jeddy3 added status: ready to implement is ready to be worked on by someone type: documentation an improvement to the documentation labels Sep 12, 2021
@sylwia-lask
Copy link
Contributor

Hi @jeddy3, I think I can do that next week, but please tell me should I branch off v14 or master?

@hudochenkov
Copy link
Member

hudochenkov commented Sep 19, 2021 via email

@ybiquitous
Copy link
Member

I believe we've rewritten all the examples. If there is what we missed, please let us know or open a pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: wip is being worked on by someone type: umbrella a group of related issues
Development

Successfully merging a pull request may close this issue.

4 participants