Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove configOverrides option #5522

Closed
Tracked by #5205
hudochenkov opened this issue Sep 12, 2021 · 4 comments
Closed
Tracked by #5205

Remove configOverrides option #5522

hudochenkov opened this issue Sep 12, 2021 · 4 comments
Labels
status: wip is being worked on by someone type: enhancement a new feature that isn't related to rules
Milestone
future-major

Comments

@hudochenkov
Copy link
Member

configOverrides in Node.js API would be quite confusing with overrides in config.

I propose to remove it in v14.
@hudochenkov hudochenkov added the status: needs discussion triage needs further discussion label Sep 12, 2021
@hudochenkov hudochenkov changed the title Remove configOverrides Remove configOverrides option Sep 12, 2021
@jeddy3
Copy link
Member

jeddy3 commented Sep 12, 2021

I agree.

@jeddy3 jeddy3 added status: ready to implement is ready to be worked on by someone type: enhancement a new feature that isn't related to rules and removed status: needs discussion triage needs further discussion labels Sep 12, 2021
@jeddy3 jeddy3 added this to the future-major milestone Sep 12, 2021
@jeddy3 jeddy3 mentioned this issue Sep 12, 2021
Closed
30 tasks
@hudochenkov
Copy link
Member Author

I can look into it as soon #5521 merged.

@hudochenkov hudochenkov added the status: wip is being worked on by someone label Sep 12, 2021
hudochenkov added a commit that referenced this issue Sep 12, 2021
@hudochenkov
Remove configOverrides option (#5522)
e2cf95c
@hudochenkov
Copy link
Member Author

Code is ready. Waiting for #5521 to be merged. Then I could send a PR.

hudochenkov added a commit that referenced this issue Sep 13, 2021
@hudochenkov
Remove configOverrides option (#5522)
87eb148
@hudochenkov hudochenkov mentioned this issue Sep 13, 2021
Merged
@jeddy3 jeddy3 mentioned this issue Sep 14, 2021
Closed
jeddy3 pushed a commit that referenced this issue Sep 14, 2021
@hudochenkov
Remove configOverrides option (#5522) (#5530)
56a4a76 
* Remove `configOverrides` option (#5522)

* Move deepmerge to devDependencies
@jeddy3 jeddy3 removed the status: ready to implement is ready to be worked on by someone label Sep 14, 2021
@jeddy3
Copy link
Member

jeddy3 commented Sep 14, 2021

Done in #5530

@jeddy3 jeddy3 closed this as completed Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: wip is being worked on by someone type: enhancement a new feature that isn't related to rules
Milestone
future-major
Development

No branches or pull requests
2 participants
@hudochenkov @jeddy3