Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove configOverrides option (#5522) #5530

Merged
merged 2 commits into from Sep 14, 2021
Merged

Remove configOverrides option (#5522) #5530

merged 2 commits into from Sep 14, 2021

Conversation

hudochenkov
Copy link
Member

Which issue, if any, is this issue related to?

Closes #5522

@@ -40,7 +40,7 @@ const EXIT_CODE_ERROR = 2;
* @property {boolean} [reportInvalidScopeDisables]
* @property {boolean} [reportDescriptionlessDisables]
* @property {number} [maxWarnings]
* @property {string | boolean} quiet
* @property {boolean} quiet
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't know why it was string. Seems to me no different to other booleans.

Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

(Failing test is an unrelated flaky one.)

Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👏🏼

@ybiquitous
Copy link
Member

I've retried CI to fix the flaky test failure.

@jeddy3 jeddy3 merged commit 56a4a76 into v14 Sep 14, 2021
@jeddy3 jeddy3 deleted the remove-configoverrides branch September 14, 2021 15:44
@jeddy3
Copy link
Member

jeddy3 commented Sep 14, 2021

  • Removed: configOverrides option (#5530).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants