New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove configOverrides
option (#5522)
#5530
Conversation
@@ -40,7 +40,7 @@ const EXIT_CODE_ERROR = 2; | |||
* @property {boolean} [reportInvalidScopeDisables] | |||
* @property {boolean} [reportDescriptionlessDisables] | |||
* @property {number} [maxWarnings] | |||
* @property {string | boolean} quiet | |||
* @property {boolean} quiet |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't know why it was string
. Seems to me no different to other booleans.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
(Failing test is an unrelated flaky one.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👏🏼
I've retried CI to fix the flaky test failure. |
|
Closes #5522