Fix trailing zeroes being removed by autofix in length-zero-no-unit #5256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeddy3
commented
Apr 21, 2021
| @@ -318,7 +326,7 @@ testRule({ | |||
| }, | |||
| { | |||
| code: 'a { top: 0.000px; }', | |||
| fixed: 'a { top: 0; }', | |||
| fixed: 'a { top: 0.000; }', | |||
There was a problem hiding this comment.
Should have been outside the scope of this rule in favour of number-no-trailing-zeros.
There was a problem hiding this comment.
Agreed. 👍🏼
So, this change may be a bug fix, not a refactoring?
(maybe, this PR title is confusing... 🤔 )
ybiquitous
reviewed
Apr 23, 2021
| @@ -318,7 +326,7 @@ testRule({ | |||
| }, | |||
| { | |||
| code: 'a { top: 0.000px; }', | |||
| fixed: 'a { top: 0; }', | |||
| fixed: 'a { top: 0.000; }', | |||
There was a problem hiding this comment.
Agreed. 👍🏼
So, this change may be a bug fix, not a refactoring?
(maybe, this PR title is confusing... 🤔 )
|
@ybiquitous Thanks for the review! Good catches and suggestions.
Yes, it started out as a refactor but fixed a bug. I'll change the title, and as such, the changelog entry. |
jeddy3
changed the title
|
This was referenced Apr 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5255
It makes use of patterns found in our more recent rules.