Add named-grid-areas-no-invalid #5167
Conversation
Node version 10, supported by the test matrix, does not support .matchAll
because node version 10 does not support `Array.prototype.flat`
There was a problem hiding this comment.
@evrom Thank you for contributing! The pull request is looking good.
I've requested a few changes. We'll want to make use of the value parser. This is probably the biggest revision. I've also requested a few changes to align the rule with our conventions so its consistent with other rules.
Once these are in place, it'll be easier to review the other workings of the rule.
(As this rule is candidate for the recommended config, we'll want to be comphensive in our tests as it's likely this rule will be run against a lot of code bases.)
Co-authored-by: Richard Hallows <jeddy3@users.noreply.github.com>
Co-authored-by: Richard Hallows <jeddy3@users.noreply.github.com>
Co-authored-by: Richard Hallows <jeddy3@users.noreply.github.com>
Co-authored-by: Richard Hallows <jeddy3@users.noreply.github.com>
Co-authored-by: Richard Hallows <jeddy3@users.noreply.github.com>
as recommended stylelint#5167 (comment)
adds checks for invalid symbols adds empty row checker
sort the non-contiguous area names alphabetically to ensure consistency in error messages
There was a problem hiding this comment.
@evrom Thank you for making all those changes! Things are looking good and I think the rule is taking shape.
I've requested some more changes.
We should focus the rule on just this part of the spec:
All strings must define the same number of cell tokens (named cell tokens and/or null cell tokens), and at least one cell token, or else the declaration is invalid. If a named grid area spans multiple grid cells, but those cells do not form a single filled-in rectangle, the declaration is invalid.
i.e.:
- All strings must define at least one cell token.
- All strings must define the same number of cell tokens.
- All named grid areas that span multiple grid cells must form a single filled-in rectangle.
A few of the requested changes are around doing this.
Does that sound good to you? It may deviate from your original validator, though.
Closes #5155
Adds rule to validate CSS grid areas to the spec defined here: https://drafts.csswg.org/css-grid/#grid-template-areas-property