Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the pattern in "*-pattern" rule messages #4974

Closed
omril321 opened this issue Oct 10, 2020 · 0 comments · Fixed by #4975
Closed

Add the pattern in "*-pattern" rule messages #4974

omril321 opened this issue Oct 10, 2020 · 0 comments · Fixed by #4975
Labels
status: wip is being worked on by someone type: enhancement a new feature that isn't related to rules

Comments

@omril321
Copy link
Contributor

What is the problem you're trying to solve?

Some *-pattern rules do not print the pattern on their messages. This may be confusing the the users, since they may not may which pattern they must follow.

What solution would you like to see?

As mentioned on #4962 (comment), *-pattern rules should specify the pattern on their messages. For example:
Expected custom media query name to match specified pattern *<pattern goes here>*

The *-pattern rules I've found which do not specify the pattern are:

  1. custom-media-pattern
  2. custom-property-pattern
  3. keyframes-name-pattern
  4. selector-class-pattern
  5. selector-id-pattern
  6. selector-nested-pattern
@hudochenkov hudochenkov added the status: wip is being worked on by someone label Oct 10, 2020
@hudochenkov hudochenkov added the status: ready to implement is ready to be worked on by someone label Oct 10, 2020
@jeddy3 jeddy3 added type: enhancement a new feature that isn't related to rules and removed status: ready to implement is ready to be worked on by someone labels Oct 11, 2020
@jeddy3 jeddy3 changed the title Show the pattern in "*-pattern" rule messages Add the pattern in "*-pattern" rule messages Oct 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: wip is being worked on by someone type: enhancement a new feature that isn't related to rules
Development

Successfully merging a pull request may close this issue.

3 participants