Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show the pattern in "*-pattern" rule messages (#4974) #4975

Merged
merged 1 commit into from Oct 15, 2020
Merged

Show the pattern in "*-pattern" rule messages (#4974) #4975

merged 1 commit into from Oct 15, 2020

Conversation

hudochenkov
Copy link
Member

@hudochenkov hudochenkov commented Oct 10, 2020 •
edited

Which issue, if any, is this issue related to?

Closes #4974.

Is there anything in the PR that needs further explanation?

No, it's self-explanatory.

jeddy3
jeddy3 approved these changes Oct 11, 2020
View reviewed changes
Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

ybiquitous
ybiquitous approved these changes Oct 13, 2020
View reviewed changes
Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

BTW, I've noticed Close #4974 is not present in this PR description. Intentional?

@hudochenkov hudochenkov merged commit 1ba8d6a into master Oct 15, 2020
@hudochenkov hudochenkov deleted the 4974-pattern-message branch October 15, 2020 20:01
@hudochenkov
Copy link
Member Author

  • Added: configured pattern in *-pattern rules violation message (#4975).

m-allanson added a commit that referenced this pull request Nov 5, 2020
@m-allanson
Merge branch 'master' into browser-bundle
d9f9b80 
* master: (46 commits)
  Update CHANGELOG.md
  Add ignoreAtRules to property-no-unknown (#4965)
  Bump eslint from 7.11.0 to 7.12.1 (#5017)
  Bump typescript from 4.0.3 to 4.0.5 (#5016)
  Bump lint-staged from 10.4.0 to 10.5.1 (#5014)
  Bump remark-cli from 8.0.1 to 9.0.0 (#4996)
  Bump jest-circus from 26.5.3 to 26.6.1 (#5009)
  Bump got from 11.7.0 to 11.8.0 (#5007)
  Bump jest from 26.5.3 to 26.6.1 (#5008)
  Refactor formatter tests (#4988)
  Fix `isStandardSyntaxDeclaration.test.js` that use callbacks (#4972)
  Update CHANGELOG.md
  Add "comment-pattern" rule (#4962)
  Update CHANGELOG.md
  Show the pattern in "*-pattern" rule messages (#4975)
  Enable ESLint `no-shadow` and add disable comments (#4986)
  Report disables in the same manner as lints (#4973)
  Update dependencies (#4982)
  Fix some tests that use callbacks (#4970)
  Use own vendor utility instead of PostCSS (#4942) (#4963)
  ...
This was referenced Mar 8, 2021
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Mar 15, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ybiquitous ybiquitous ybiquitous approved these changes

@jeddy3 jeddy3 jeddy3 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add the pattern in "*-pattern" rule messages
3 participants
@hudochenkov @ybiquitous @jeddy3