Report disable errors the same way as lint errors

[nex3]

What is the problem you're trying to solve?

Currently, errors caused by reportNeedlessDisables, reportInvalidScopeDisables, and eventually reportUnscopedDisables (#2292) and reportDisables (#4875) are reported in a format that's inconsistent with (and less visually appealing than) the way normal lints are recorded.

What solution would you like to see?

I propose that these disable issues instead be converted to the same object structure as lints, and be passed to the standard lint formatter to be reported appropriately. That way they'll automatically play nicely with both default and custom formatters, and look consistent with the most common reports.

[jeddy3]

Sounds good to me. I don't know why we didn't do that originally.

[edg2s]

Is there a reason these are styled with red x's in the output, instead of yellow warning triangles as is used for other warnings?

[nex3]

Stylelint makes the distinction between "warnings" (displayed with yellow triangles) and "errors" (displayed with red Xs). Normally, lints have a way of configuring which type they'll be reported as, but since these aren't configurable in the same way we had to make a choice—I chose errors, to match the idea that failing one of these requirements would cause the linter to produce a non-zero exit code.

[edg2s]

I get a 0 exit code with these in the command line:

$ ./node_modules/stylelint/bin/stylelint.js --rd src/styles/widgets/SelectFileWidget.less 

src/styles/widgets/SelectFileWidget.less
 21:4  ✖  Needless disable for "plugin/no-unsupported-browser-features"  --report-needless-disables

$ echo $?
0

Similarly, using the Node API, the "errored" flag is not set, and these are marked as warnings.

[nex3]

I'm surprised by that, but I'm afraid you've reached the limit of my stylelint expertise 🤷‍♀️. Maybe one of the more experienced maintainers could chime in?

[XhmikosR]

I opened #5046 this morning for the wrong error code.

[vankop]

As I see regression is here #4973

We need to hit this condition

stylelint/lib/prepareReturnValue.js

Line 36 in 0fdef35

const errored = stylelintResults.some(

for
https://github.com/stylelint/stylelint/blob/master/lib/cli.js#L563

feel free to send a PR

[jeddy3]

@vankop Thanks for identifying a possible fix!

Let's track the regression in @XhmikosR new issue: #5046