Report disables in the same manner as lints #4973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than returning disables that are considered "invalid" for various reasons (such as --report-needless-disables) as a separate list of objects that formatters must handle individually, stylelint now converts them into standard lint warnings. This allows formatters to automatically format them the same as normal warnings without any extra disable-specific code. Closes #4896
nex3
force-pushed
the
lintlike-disable-reports
branch
from
11b6b83
to
2c392c6
Compare
jathak
approved these changes
Oct 9, 2020
vankop
reviewed
Oct 12, 2020
vankop
approved these changes
Oct 14, 2020
m-allanson
added a commit
that referenced
this pull request
Nov 5, 2020
* master: (46 commits) Update CHANGELOG.md Add ignoreAtRules to property-no-unknown (#4965) Bump eslint from 7.11.0 to 7.12.1 (#5017) Bump typescript from 4.0.3 to 4.0.5 (#5016) Bump lint-staged from 10.4.0 to 10.5.1 (#5014) Bump remark-cli from 8.0.1 to 9.0.0 (#4996) Bump jest-circus from 26.5.3 to 26.6.1 (#5009) Bump got from 11.7.0 to 11.8.0 (#5007) Bump jest from 26.5.3 to 26.6.1 (#5008) Refactor formatter tests (#4988) Fix `isStandardSyntaxDeclaration.test.js` that use callbacks (#4972) Update CHANGELOG.md Add "comment-pattern" rule (#4962) Update CHANGELOG.md Show the pattern in "*-pattern" rule messages (#4975) Enable ESLint `no-shadow` and add disable comments (#4986) Report disables in the same manner as lints (#4973) Update dependencies (#4982) Fix some tests that use callbacks (#4970) Use own vendor utility instead of PostCSS (#4942) (#4963) ...
jeddy3
pushed a commit
that referenced
this pull request
Feb 6, 2021
* Remove unused disable-reporting code This was outmoded by #4973 * Allow disable reporting to be controlled from the config file This will also make it easier to control disables on a file-by-file basis once #3128 is implemented. It will also make it possible to add finer-grained configuration to these rules in the future. * Fix a typo Co-authored-by: Jennifer Thakar <jathak@google.com> * Code review changes Co-authored-by: Jennifer Thakar <jathak@google.com>
This was referenced Mar 8, 2021
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than returning disables that are considered "invalid" for
various reasons (such as --report-needless-disables) as a separate
list of objects that formatters must handle individually, stylelint
now converts them into standard lint warnings. This allows formatters
to automatically format them the same as normal warnings without any
extra disable-specific code.
Closes #4896