Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add hue-degree-notation #4769

Merged
merged 1 commit into from May 19, 2020
Merged

Add hue-degree-notation #4769

merged 1 commit into from May 19, 2020

Conversation

jeddy3
Copy link
Member

@jeddy3 jeddy3 commented May 13, 2020

Which issue, if any, is this issue related to?

Closes #4721

Is there anything in the PR that needs further explanation?

The rule can autofix both primary options as this rule is about explicitness vs shorthand convenience (with neither option being more right than the other), unlike color-function-notation which is concerned with modern vs legacy syntax.

@jeddy3 jeddy3 mentioned this pull request May 14, 2020
Closed
6 tasks
m-allanson
m-allanson approved these changes May 14, 2020
View reviewed changes
Copy link
Member

@m-allanson m-allanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good.

@jeddy3 jeddy3 mentioned this pull request May 17, 2020
Closed
6 tasks
mattxwang
mattxwang reviewed May 18, 2020
View reviewed changes
Copy link
Member

@mattxwang mattxwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit new to this, but should we discuss the behaviour of the rule in regards to CSS functions and variables (e.g. calc() and var())? I see it covered in the test cases, but not in the documentation.

@jeddy3
Copy link
Member Author

jeddy3 commented May 18, 2020

but should we discuss the behaviour of the rule in regards to CSS functions and variables (e.g. calc() and var())?

@malsf21 The documentation for rules tend to focus on the simplest example, as to communicate the intent of the rule. Each rule usually has countless edge-cases that would if documented make the intent of the rule more difficult to understand.

mattxwang
mattxwang approved these changes May 18, 2020
View reviewed changes
Copy link
Member

@mattxwang mattxwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha, then I think this LGTM! 👍

@jeddy3 jeddy3 merged commit ff2de42 into master May 19, 2020
@jeddy3 jeddy3 deleted the issue-4721 branch May 19, 2020 12:46
@jeddy3
Copy link
Member Author

jeddy3 commented May 19, 2020

Changelog:

  • Added: hue-degree-notation rule (#4769).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathiasbynens mathiasbynens mathiasbynens approved these changes

@m-allanson m-allanson m-allanson approved these changes

@mattxwang mattxwang mattxwang approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add hue-degree-notation
4 participants
@jeddy3 @mathiasbynens @m-allanson @mattxwang