Add Node.js 12 to CIs #4072
Add Node.js 12 to CIs #4072
Conversation
|
The AppVeyor build was failed because of appveyor/ci#2921. |
|
/cc @stylelint/core what do you think about migrate on azure pipelines, i can take care about this |
I'd rather we switched our Windows build to Travis CI per #3716 when we can |
|
An aside, I've not time to look into this right now, but over in stylelint-config-wordpress I'm getting failed Jest snapshots for Node.js 12, I've restarted the tests numerous times but they continue to fail on v12 but pass on v10 and v8 /shrug https://travis-ci.org/WordPress-Coding-Standards/stylelint-config-wordpress/builds/529146586 |
|
Actually, Jest has an issue with the See jestjs/jest#8397 |
|
Actually, I also have failed tests on Node 12. I don't know the reason yet... 🤔 Node 12 (failed): Node 10 (passed): In my case, |
|
/cc @ntwb Travis has poor support lately, and their CI is not very fast, unlike azure pipelines. I migrate on azure pipelines in many OSS projects and commercial and it is awesome |
|
please see also nodejs/node#25060 |
|
Guys let's migrate on azure pipelines, it is really faster and stable |
|
Let's remove appveyor file from this PR and merge it.
@evilebottnawi are there articles comparing Azure Pipelines and Travis? If it's faster I think it's easier to have one CI instead of two. Would you like to create PR so we can see how fast and good it is? |
hudochenkov
added
PR: needs revision
and removed
pr: blocked
|
@hudochenkov no articles, just my experience in webpack and webpack ecosystem
Yes, in my todo (do it tomorrow) |
|
Hi, I try the workaround anyway. 💪 |
|
The workaround works well! 😄 See the build log: |
|
WIP on azure pipelines |
|
We should merge this PR any way to be able to compare time with all Node.js versions. |
|
Feel free to merge |
| install: | ||
| - ps: Install-Product node $env:nodejs_version | ||
| # Workaround from https://github.com/appveyor/ci/issues/2921#issuecomment-486727727 | ||
| # https://www.appveyor.com/docs/lang/nodejs-iojs/#installing-any-version-of-nodejs-or-iojs |
There was a problem hiding this comment.
One thing this shows is how out of date the AppVeyor dos are :(
They continue to reference Node.js v5.x and iojs 🤦🏼♂️
|
Oh, Node 12 seems to be available on AppVeyor. |
Node.js 12 was released on 2019-04-23, which is the Current Release version.
See https://github.com/nodejs/Release#release-schedule.
Related to #3299.
See Node.js 12 changelog.