Lint staged files on pre-commit hook #3906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should we also run eslint as part of the precommit hook? |
|
Make sense. I will push a new commit to this PR and change the PR title. 👌 |
Because we may not notice the lint errors until our CI occurs them.
ybiquitous
changed the title
remark for committing markdown files
ybiquitous
changed the title
ybiquitous
commented
Jan 19, 2019
package.json
Outdated
| @@ -140,7 +140,11 @@ | |||
| "lint-staged": { | |||
| "*.js": [ | |||
| "prettier --write", | |||
| "eslint --max-warnings=0", | |||
There was a problem hiding this comment.
[note] I excluded --cache option to lint files in the clean state. I think it no performance problem because of not for all JS files in the project.
Done. Please review again. 🙏 |
hudochenkov
reviewed
Jan 19, 2019
Co-Authored-By: ybiquitous <473530+ybiquitous@users.noreply.github.com>
jeddy3
approved these changes
Jan 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
None. This PR aims to improve our DX (Developer eXperience).
Because we may not notice the lint errors until our CI occurs them.