made use of prev method on childNode + added check descendant combina…

…tor type
stylelint · Aug 17, 2022 · ef7630f · ef7630f
1 parent 7244516
commit ef7630f
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 11 deletions.
diff --git a/lib/rules/selector-max-universal/__tests__/index.js b/lib/rules/selector-max-universal/__tests__/index.js
@@ -321,18 +321,12 @@ testRule({
 
 testRule({
 	ruleName,
-	config: [0, { ignoreAfterCombinators: ['~', '+', '>', 'h1', 'article'] }],
+	config: [0, { ignoreAfterCombinators: ['~', '+', '>'] }],
 
 	accept: [
 		{
 			code: '.foo {}',
 		},
-		{
-			code: 'article * {}',
-		},
-		{
-			code: 'h1 * {}',
-		},
 		{
 			code: '.foo ~ * {}',
 		},

diff --git a/lib/rules/selector-max-universal/index.js b/lib/rules/selector-max-universal/index.js
@@ -52,19 +52,19 @@ const rule = (primary, secondaryOptions) => {
 		 * @param {import('postcss').Rule} ruleNode
 		 */
 		function checkSelector(selectorNode, ruleNode) {
-			const count = selectorNode.reduce((total, childNode, index, nodes) => {
+			const count = selectorNode.reduce((total, childNode) => {
 				// Only traverse inside actual selectors
 				// All logical combinations will be resolved as nested selector in `postcss-resolve-nested-selector`
 				if (childNode.type === 'selector') {
 					checkSelector(childNode, ruleNode);
 				}
 
-				let prevChildNode = nodes[index - 1];
+				let prevChildNode = childNode.prev();
 				let prevChildNodeValue = prevChildNode && prevChildNode.value;
 
 				// checks if previous child node is descendant combinator
-				if (prevChildNodeValue === ' ') {
-					prevChildNode = nodes[index - 2];
+				if (prevChildNode && prevChildNode.type === 'combinator' && prevChildNodeValue === ' ') {
+					prevChildNode = prevChildNode.prev();
 
 					prevChildNodeValue = prevChildNode && prevChildNode.value;
 				}